Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #790, #792, #803: Delete/Generate next-gen in media not working #807

Merged
merged 17 commits into from
Feb 22, 2024
Merged

Closes #790, #792, #803: Delete/Generate next-gen in media not working #807

merged 17 commits into from
Feb 22, 2024

Conversation

jeawhanlee
Copy link
Contributor

@jeawhanlee jeawhanlee commented Feb 20, 2024 •
edited by Tabrisrp
Loading

Description

Fixes the delete/generate next-gen link not working.

Fixes #790, #792, #803

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I did not introduce unecessary complexity.

@jeawhanlee jeawhanlee self-assigned this Feb 20, 2024
@jeawhanlee jeawhanlee mentioned this pull request Feb 20, 2024
Closed
19 tasks
@jeawhanlee jeawhanlee requested a review from a team February 20, 2024 09:58
This was linked to issues Feb 20, 2024
Reoptimize image in media library isnot working #790
Closed
Delete/Generate Next-Gen in media library isnot working #792
Closed
@Tabrisrp
Copy link
Contributor

There is some duplicate here with this PR #804

Tabrisrp
Tabrisrp requested changes Feb 20, 2024
View reviewed changes
inc/classes/class-imagify-files-list-table.php Outdated Show resolved Hide resolved
classes/Optimization/Process/AbstractProcess.php Outdated Show resolved Hide resolved
@jeawhanlee
Copy link
Contributor Author

@Tabrisrp What do we do about the duplicates?

@Tabrisrp Tabrisrp mentioned this pull request Feb 21, 2024
Closed
6 tasks
@Tabrisrp Tabrisrp linked an issue Feb 21, 2024 that may be closed by this pull request
In edit image page if we click generate next-Gen image, we will be redirected to imagify settings page #803
Closed
@Tabrisrp Tabrisrp changed the title Closes #792: Delete/Generate next-gen in media not working Closes #790, #792, #803: Delete/Generate next-gen in media not working Feb 21, 2024
@Mai-Saad
Copy link

Mai-Saad commented Feb 22, 2024 •
edited
Loading

@jeawhanlee Thanks for the PR, please find my notes below:

  • click generate next-Gen (generating webP /AVIF based on option enabled) 🎉 , while delete next gen will delete only webP files even if avif files are there while AVIF option is disabled (in this case, we shall delete both webp and avif). can you please check?
    steps:
    1- on branch
    2- enable create avif
    3- upload image => avif created
    4- switch to trunk and enable create webP
    5- click generate webP
    6- back to branch => click delete next-gen (AVIF option is disabled)
    expected: delete both webP and AVIF
    actual: only webP is deleted

  • When should generate/ delete link be displayed is not handled on this PR. will add separate GH about it

@Miraeld Miraeld mentioned this pull request Feb 22, 2024
Merged
9 tasks
@Tabrisrp Tabrisrp merged commit 4502844 into feature/avif Feb 22, 2024
1 check passed
@Tabrisrp Tabrisrp deleted the fix/792-delete-generate-next-gen-in-media-not-working branch February 22, 2024 16:05
@Mai-Saad Mai-Saad mentioned this pull request Feb 26, 2024
Closed
@jeawhanlee jeawhanlee mentioned this pull request Feb 27, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Awaiting requested review from Tabrisrp

Assignees

@jeawhanlee jeawhanlee

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jeawhanlee @Tabrisrp @Mai-Saad